Free should support fx syntax #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aballano
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Thank you for the PR @PhBastiani! Let's get another maintainer's ok with this and we can merge 👍
pakoito
reviewed
Jan 28, 2020
| } | ||
|
|
||
| fun odd(n: Int): TrampolineF<Boolean> { | ||
| private fun odd(n: Int): TrampolineF<Boolean> { |
There was a problem hiding this comment.
It's okay to have these public.
pakoito
approved these changes
Jan 28, 2020
rachelcarmena
added a commit
that referenced
this pull request
Jan 31, 2020
* Fix: change token to sync branches (#1992) * Free should support fx syntax (#1985) * Free should support fx syntax Co-authored-by: Alberto Ballano <aballano@users.noreply.github.com> * DOCS: update slack link #arrow channel (#1989) Co-authored-by: Alberto Ballano <aballano@users.noreply.github.com> * Race in fiber raises cancellation exception (#1986) * Add explicit racePairCancellable as a lighter version of racePair, without promises Made all IO raceN functions depend on racePairCancellable * Remove upstreamCancelToken from racePair and raceTriple, fixing the issue * Changed tests IORacePair and IORaceTriple to use raceN Co-authored-by: Alberto Ballano <aballano@users.noreply.github.com> * Docs: add ank to snippets and update documentation (#1997) * Add queue functor (#1904) * ADD: HandleErrorWith to Either implementaion * ADD: Queue Functor * ADD: Queue Functor * ADD: Queue Invariant * FIX: Queue errors * FIX: Queue errors Co-authored-by: Paco <pakoito@users.noreply.github.com> Co-authored-by: Raúl Raja Martínez <raulraja@gmail.com> * Add a stacksafe variant of Join to AndThen (#2005) * Fix Async and Concurrent fx block's lazyness (#1978) * Add Async law to check for fx lazyness Also remove defer from each Fx instance in order to make the tests fail before more generic fix * Made Async and Concurrent Fx instances to run deferred * Remove intermediate variables from MonadFx tree by narrowing the instance type on each subtype * Removed fx lazyness specific test in favour of generic law Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Rachel M. Carmena <rachelcarmena@users.noreply.github.com> Co-authored-by: Philippe Bastiani <900472+PhBastiani@users.noreply.github.com> Co-authored-by: Alberto Ballano <aballano@users.noreply.github.com> Co-authored-by: Renneville Guybert <bobkilla@users.noreply.github.com> Co-authored-by: danieh <danimontoya_86@hotmail.com> Co-authored-by: kioba <charlssom@gmail.com> Co-authored-by: Paco <pakoito@users.noreply.github.com> Co-authored-by: Raúl Raja Martínez <raulraja@gmail.com> Co-authored-by: Jannis <overesch.jannis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add the syntax fx to the Free monads.