Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU-fv6x6d Clean up Arrow Fx based on API Review #2329

Merged
merged 3 commits into from
Mar 18, 2021
Merged

CU-fv6x6d Clean up Arrow Fx based on API Review #2329

merged 3 commits into from
Mar 18, 2021

Conversation

nomisRev
Copy link
Member

This PR cleans up the API for Arrow Syntax for Arrow 0.13.0 (1.0.0). The API review can be found here

  • Revert CancellableContinuation changes
  • Remove Resource.unit
  • Clean-up Resource traverse API
  • Add deprecation UnsafePromise

@nomisRev nomisRev requested a review from a team March 17, 2021 13:51
@franciscodr
Copy link
Collaborator

Task linked: CU-fv6x6d Clean-up Arrow Fx after API review

raulraja
raulraja approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nomisRev !

@i-walker i-walker merged commit 767490e into master Mar 18, 2021
@i-walker i-walker deleted the cu-fv6x6d-clean-up-arrow-fx-review branch March 18, 2021 16:16
@nomisRev nomisRev mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@i-walker i-walker i-walker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nomisRev @franciscodr @raulraja @i-walker