Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alternative #256

Merged
merged 6 commits into from
Sep 5, 2017
Merged

Add Alternative #256

merged 6 commits into from
Sep 5, 2017

Conversation

JorgeCastilloPrz
Copy link
Member

Fixes #249

This one is very simple. Just added Alternative typeclass with no methods (since the only one it contains is the composed one and it's defined as an extension function on the Composed file.

Wanted to write WriterT instance for Alternative but was not possible due to WriterT over constraints, since it's asking for a Monad and not a Functor.

MonadCombine almost all the instances for Alternative, so will be done in a different PR.

@JorgeCastilloPrz JorgeCastilloPrz self-assigned this Sep 5, 2017
@JorgeCastilloPrz JorgeCastilloPrz changed the title Jorge alternative Add Alternative Sep 5, 2017
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8c811ef). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #256   +/-   ##
=========================================
  Coverage          ?   49.98%           
  Complexity        ?      247           
=========================================
  Files             ?      114           
  Lines             ?     2563           
  Branches          ?      293           
=========================================
  Hits              ?     1281           
  Misses            ?     1167           
  Partials          ?      115
Impacted Files Coverage Δ Complexity Δ
.../main/kotlin/kategory/instances/StateTInstances.kt 87.5% <ø> (ø) 0 <0> (?)
...y/src/main/kotlin/kategory/typeclasses/Composed.kt 67.64% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c811ef...59f6113. Read the comment docs.

@JorgeCastilloPrz JorgeCastilloPrz merged commit 0e77607 into master Sep 5, 2017
@JorgeCastilloPrz JorgeCastilloPrz deleted the jorge-alternative branch September 5, 2017 19:31
@wiyarmir wiyarmir mentioned this pull request Sep 15, 2017
rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants