Allow exception to propagate from fold Success function #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In spirit of cats, don't handle exceptions in a Try.fold.
|
Hi guys! I guess you've made a really explicit choice to include this behavior. I hope you will consider changing it, it really confused me in our code base. Cheers, |
pakoito
approved these changes
Mar 21, 2018
|
I believe it was me who made the change. I don't feel strongly for or against it. The version in this PR is more correct specially coming from Scala, but less user-friendly for the Java people :D |
|
As a Java person, I agree with the change - it would be a real headache to track down that it was the success function that was causing the failure, not the previous function! |
|
Merged it is! |
|
That was quick, awesome, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling a failed Success as if it was the same as original Failure is not the way it is done in cats. I would argue this makes for a better fold function.