[WIP] Updating kotlintest to 3.0 #786
Conversation
| override fun always() = listOf(RuntimeException(), NoSuchElementException(), IllegalArgumentException()) | ||
|
|
||
| override fun random(): Sequence<Throwable> { | ||
| return Gen.from(always()).random() |
There was a problem hiding this comment.
Can you please fix the Gen.from to a field so it keeps the seed across calls? This was a bug on the previous implementation.
There was a problem hiding this comment.
The main problem with 3.0 is that random returns sequence that can be used only one time. So tests will crash when random will be invoked and used second time.
There was a problem hiding this comment.
Ooooooooooh. I see. It's different now. Yeah ignore this and the other I'll comment on.
There was a problem hiding this comment.
So I guess, I was wrong.
| res.equalUnderTheLaw(just(iter), EQ) | ||
| } | ||
| fun <F> Monad<F>.stackSafety(iterations: Int = 5000, EQ: Eq<Kind<F, Int>>): Unit = Unit | ||
| // forFew(1, Gen.oneOf(listOf(iterations))) { iter -> |
There was a problem hiding this comment.
I think forFew doesn't exist anymore
There was a problem hiding this comment.
It's in arrow-test, I wrote it for tests that'd cause OOMs on CI :D
| fun <A : Any> genNullable(genA: Gen<A>): Gen<A?> = object: Gen<A?> { | ||
| override fun always(): Iterable<A?> = emptyList() | ||
|
|
||
| override fun random(): Sequence<A?> = oneOf(genA, Gen.create { Option.empty<A>() }).random().map { |
There was a problem hiding this comment.
We need to capture oneOf(..) as a field, and only call random here, to not reset the seed on every call.
Can't we use Gen.create { null } on 3.X?
There was a problem hiding this comment.
No, sequences cannot have null values in stream.
There was a problem hiding this comment.
:( Can use use another marker value? Like, a literal value we create inside the class with an identity that will not overlap with A? Maybe compare using ===?
There was a problem hiding this comment.
I was wrong here also, sequence can have null values, but sequences generated throught generateSequence cannot (because null defines the end of the stream)
| is E -> Left(it) | ||
| is A -> Right(it) | ||
| else -> throw IllegalStateException("genEither incorrect value $it") | ||
| is E -> Left(it) |
There was a problem hiding this comment.
Formatting with two spaces here!
| //// rootTestSuite.addTestCase(tc) | ||
| //// tc | ||
| // val tc = TestCase(Description(emptyList(), law.name),this@UnitSpec, { law.test()} , 0, defaultTestCaseConfig) | ||
| // } |
build.gradle
Outdated
| maxParallelForks = Runtime.runtime.availableProcessors() | ||
| } | ||
|
|
||
| // build.dependsOn ':detekt' |
| @@ -117,7 +117,7 @@ subprojects { project -> | |||
| maxParallelForks = Runtime.runtime.availableProcessors() | |||
| } | |||
|
|
|||
| build.dependsOn ':detekt' | |||
| // build.dependsOn ':detekt' | |||
There was a problem hiding this comment.
It throws errors for files in "generated" directory - I must finally fix it in config
There was a problem hiding this comment.
We only run detekt on clean builds. We normally use assemble and test rather than build to make the lib!
|
@jereksel what happened? |
|
It's superseded by #912, isn't it? |
|
Oh, right! |
A lot of things change and we'll propably have to update it anyway in the future (for JS support), so let's do this as early as possible.
TODO:
In Specs replace Gen, with () => Gen - generator can only be used one time on 3.0