[WIP] Try to improve CI build time #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arrow-kt/maintainers I changed the order in the travis file to first run tests and then run ank in order to fail fast if tests are broken. The PR build is now ~5:57min instead of ~7:15min if there´s a failure. |
raulraja
reviewed
May 29, 2018
.travis.yml
Outdated
| - ./gradlew codeCoverageReport | ||
| - bash <(curl -s https://codecov.io/bash) | ||
| - ./gradlew clean build :arrow-docs:runAnk |
There was a problem hiding this comment.
Don't we need to run the build before code coverage is reported?
There was a problem hiding this comment.
AFAIK The coverage can be run at any time after ./gradlew codeCoverageReport runs. I´ll trigger a re-run to be sure :)
This comment has been minimized.
This comment has been minimized.
raulraja
approved these changes
Jun 10, 2018
RawToast
pushed a commit
to RawToast/kategory
that referenced
this pull request
Jul 18, 2018
* Make build fail to get total time in CI. * Do coverage report first in order to fail fast * Remove test failure * Update .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ANK processor is executed before the unit tests, which wastes some time whenever the tests fail. This PR changes the execution order in order to fail fast.
For now: