AwaitAll for Traverse Deferred<T> #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakoito
reviewed
Jun 22, 2018
| "awaitAll called on a Traverse instance of DeferredK<T> should return a Traverse instance of T" { | ||
| forAll(Gen.int(), { | ||
| runBlocking { | ||
| checkAwaitAll(ListK.applicative(), ListK.traverse(), it) |
There was a problem hiding this comment.
If any of these fails, it just returns a boolean that's ignored. You have to && them!
If you were not using forAll you'd have to use shouldBe in checkAwaitAll, which throws an AssertionException instead.
There was a problem hiding this comment.
eek, school boy error. Thanks
pakoito
reviewed
Jun 22, 2018
| @@ -20,6 +31,9 @@ class DeferredKTest : UnitSpec() { | |||
| a.unsafeAttemptSync() == b.unsafeAttemptSync() | |||
| } | |||
|
|
|||
| suspend fun <F, A> checkAwaitAll(AP: Applicative<F>, T: Traverse<F>, v: A) = | |||
| AP.just(DeferredK { v }).awaitAll(T) == AP.just(v) | |||
There was a problem hiding this comment.
To have more than 1 element per test I'd suggest doing something like:
suspend fun <F, A> checkAwaitAll(AP: Applicative<F>, T: Traverse<F>, col: HK<F, A>) = AP.run {
col.map { v -> DeferredK { v }}.awaitAll(T) == col
}
checkAwaitAll(.., .., listOf(it, it, it, it, it).k()) // Or generate multiple ints instead
Note that we use 2-space indentation everywhere.
richard-gibson
force-pushed
the
rg-awaitall
branch
from
de0e6bc
to
07395b9
Compare
richard-gibson
force-pushed
the
rg-awaitall
branch
from
07395b9
to
d0e8c24
Compare
RawToast
pushed a commit
to RawToast/kategory
that referenced
this pull request
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #884,
This adds awaitAll to any F<DeferredK> that returns F where F has a traverse instance