parser: allow (UTC prefix in TzInfoParser #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input like '(UTC+01:00) Amsterdam, Berlin...' couldn't be parsed by the code. Allow (UTC prefixes to the string and also ignore suffixes to the strings, as remainders are not relevant to the further computation. Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2325 2325
Branches 449 449
=========================================
Hits 2325 2325
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@anishnya @jadchaar @krisfremen any feedback on this PR? |
|
Hey @priv-kweihmann, sorry for the delay in looking at this. The changes look good to me and I've approved the PR. Just awaiting confirmation from one @jadchaar, @krisfremen, or @systemcatch here. |
anishnya
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
allow (UTC prefix in TzInfoParser
Input like '(UTC+01:00) Amsterdam, Berlin...' couldn't be parsed
by the code. Allow (UTC prefixes to the string and also ignore suffixes
to the strings, as remainders are not relevant to the further
computation.
This particular input was the TZ string send by a remote mail server