Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never return APIError from batch #210

Closed
wants to merge 1 commit into from

Conversation

seejohnrun
Copy link
Contributor

No description provided.

@arsduo
Copy link
Owner

arsduo commented May 17, 2012

Hi John,

Actually, this is very deliberate -- Facebook can return errors for individual parts of a batch request (for instance, if one user among many has revoked your application's permissions), while still successfully returning information for the rest. Raising an error here would prevent apps from using that information.

Can you tell me more about your situation? When would you want to raise the error and discard the entire request? (You can of course do this easily in your own app by just looping over the results looking for errors and raising it if you find one.)

Best,

Alex

@seejohnrun
Copy link
Contributor Author

Cool Alex,

That's actually exactly what I ended up doing. Thanks for the description of the reasoning - makes total sense

Cheers,
John C

@seejohnrun seejohnrun closed this May 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants