Manually hide transcript & credit views on Tours' Audio Details screen (AIC-646) #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2019 15:42
…yout (ViewModel handles visibility later) : AIC-646
Cliabhach
changed the title
Cliabhach
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Hmm. I've been presented (offline) with evidence that this changeset works, but I'm still a little nervous. @sam33rdhakal , I don't suppose you could look into the root cause of that 0-height measurement issue?
|
I am working to figure out the root cause 0-height measurement issue. Height of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic slightly: the
transcriptandcreditViewGroups are now visible by default. This means, of course, that we need to hide them if the currentPlayableis a Tour....