Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segments with equal names on same levels but in different parent segments #15

Closed
franzzua opened this issue Sep 24, 2013 · 2 comments · Fixed by #20
Closed

Segments with equal names on same levels but in different parent segments #15

franzzua opened this issue Sep 24, 2013 · 2 comments · Fixed by #20

Comments

@franzzua
Copy link

Switching between 's1.someName' and 's2.someName' will not refresh div[app-view-segment="1"].
Try to navigate from
http://angular-route-segment.com/src/example/#/section1/2
to
http://angular-route-segment.com/src/example/#/section2/2
using address bar

@CGenie
Copy link

CGenie commented Oct 16, 2013

Would be nice to fix this, since it's a serious bug: sub-segment names should be unique only within a given segment, but this bug requires me to make unique internal names globally in the whole application! So in the above example I have to make: s1.someName and s2.someOtherName.

JeffreyPalmer added a commit to JeffreyPalmer/angular-route-segment that referenced this issue Oct 18, 2013
@sqrter
Copy link

sqrter commented Nov 19, 2013

Thanks for fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants