-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same segment, different parameters == no segment update. #30
Comments
actually I wrongly assumed this was initiated in the directive, however the directive still makes up part of the problem by not allowing an update on same segmentname, different parameters. |
Nvm, Looking at the source code reveals: https://github.com/artch/angular-route-segment/blob/master/src/route-segment.js#L55
Which means that :
Will cause the segment to update with the routeParam Perhaps the example needs to use this in the example. |
You can also use .segment('segmentName', {
...
watcher: function(SomeService) {
return SomeService.someValue(); // if this is changed on $digest-ing, then segment will be reloaded
}
}) |
Similar to this issue: #15
Except that here is the condition:
Same url pattern thus same segement, but different parameters.
Since this is the logic that determines whether or not to update the segment, we also need to test if the parameters are different.
The text was updated successfully, but these errors were encountered: