Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "+X% Chance to Reanimate Target" attribute is parsed incorrectly #4

Open
artcom-net opened this issue Oct 9, 2020 · 3 comments
Open

The "+X% Chance to Reanimate Target" attribute is parsed incorrectly #4

artcom-net opened this issue Oct 9, 2020 · 3 comments
Assignees
@artcom-net
Labels
bug Something isn't working fixed_in_dev This issue was fixed in the dev branch

Comments

@artcom-net
Copy link
Owner

The value of this attribute consists of two parts: 10 bits is the type raised and the next 7 bits is the percentage number.
The current implementation does not take into account the percentage value itself, which is an error.
@artcom-net artcom-net added the bug Something isn't working label Oct 9, 2020
@artcom-net artcom-net self-assigned this Oct 9, 2020
@artcom-net
Copy link
Owner Author

Magic attribute ID = 155.

@artcom-net
Copy link
Owner Author

artcom-net commented Oct 9, 2020 •
edited
Loading

Types of returned:

  • 0 - Skeleton;
  • 1 - Returned;
  • 2 - BoneWarior;
  • 3 - BurningDead;
  • 4 - Horror;
  • 5 - Zombie;
  • 6 - HungryDead;
  • 7 - Ghoul.

artcom-net added a commit that referenced this issue Oct 12, 2020
@artcom-net
Fix parsing of the "+X% Chance to Reanimate Target" attribute
8f206a2 
- fixed incorrect attribute name on "X% Reanimate as: Y";
- fixed value substitution;
- added enumeration for reanimated types.

Fixes #4
@artcom-net
Copy link
Owner Author

Will be merged into master in version 1.0.0

@artcom-net artcom-net added the fixed_in_dev This issue was fixed in the dev branch label Oct 15, 2020
@artcom-net artcom-net mentioned this issue Oct 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artcom-net artcom-net

Labels
bug Something isn't working fixed_in_dev This issue was fixed in the dev branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artcom-net