Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "+X% Chance to Reanimate Target" attribute is parsed incorrectly #14

Open
artcom-net opened this issue Oct 24, 2020 · 1 comment
Open

Comments

@artcom-net
Copy link
Contributor

Hi there!
The value of this attribute consists of two parts: 10 bits is the type raised and the next 7 bits is the percentage number.
The current implementation does not take into account the percentage value itself, which is an error.

I fixed this problem in my Python library artcom-net/d2lib#4.
If I find the time I will make a pull request.

@nokka
Copy link
Owner

nokka commented Nov 9, 2020

Thank you, I'll have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants