Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: dependency declaration is overly verbose #38

Closed
jrwdunham opened this issue Mar 8, 2018 · 0 comments
Closed

Problem: dependency declaration is overly verbose #38

jrwdunham opened this issue Mar 8, 2018 · 0 comments
Assignees
@jrwdunham

Comments

@jrwdunham
Copy link
Contributor

In order to declare a dependency, e.g., in the FSEntry class, we currently write:

premis_object_class = Dependency('premis_object_class', ...)

Providing the dependency name as first argument is unnecessarily verbose given that the same name is provided as the managed class's class attribute, e.g., FSEntry.premis_object_class. It would be better if we could write:

premis_object_class = Dependency(...)
@jrwdunham jrwdunham self-assigned this Mar 8, 2018
jrwdunham added a commit that referenced this issue Mar 8, 2018
@jrwdunham
Reduce dependency declaration verbosity
53ff23d 
Use metaprogramming so that dependencies can be declared without
redundantly specifying the name of the dependency.

Fixes #38
@jrwdunham jrwdunham mentioned this issue Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrwdunham jrwdunham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrwdunham