Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Image URLs in some example CSVs no longer work #1781

Closed
mcantelon opened this issue Mar 21, 2024 · 2 comments · Fixed by #1782
Closed

Problem: Image URLs in some example CSVs no longer work #1781

mcantelon opened this issue Mar 21, 2024 · 2 comments · Fixed by #1782
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone

Comments

@mcantelon
Copy link
Member

Current Behavior

Importing example CSVs containing URLs to images results in no images being imported due to the URLs no longer working.

Examples:

  • php symfony csv:import lib/task/import/example/isad/example_information_objects_isad.csv
  • php symfony csv:import lib/task/import/example/rad/example_information_objects_rad.csv
  • php symfony csv:authority-import lib/task/import/example/authority_records/example_authority_records.csv

Expected Behavior

Images should end up getting imported.

Possible Solution

Use very old image from web.

https://graphics.stanford.edu/courses/cs348b-competition/cs348b-92/newman.monitor.jpg (circa 1992)

Context and Notes

I use this to test import functionality and these CSVs get used as references for users.

Version used

No response

Operating System and version

No response

Default installation culture

en

PHP version

7.4.3

Contact details

No response

@mcantelon mcantelon added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Mar 21, 2024
mcantelon added a commit that referenced this issue Mar 21, 2024
Replace image URLs in example import CSVs with an image that's been on
the web since 1992.
@anvit anvit linked a pull request Mar 26, 2024 that will close this issue
mcantelon added a commit that referenced this issue Mar 26, 2024
Replace image URLs in example import CSVs with an image that's been on
the web since 1992.
@anvit anvit added this to the 2.8.2 milestone May 16, 2024
@fiver-watson
Copy link
Contributor

@anvit just FYI - much of the AtoM community, not being developers, get their copy of the CSV templates from the wiki, here:

If there have been changes to the default templates - even just to update broken links in the sample rows - it would be good to add those to the wiki page!

@anvit
Copy link
Contributor

anvit commented May 17, 2024

@fiver-watson Thanks! I've added the updated templates to the wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants