Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cultureFallback contacts, refs #11359 #584

Closed
wants to merge 2 commits into from
Closed

Add cultureFallback contacts, refs #11359 #584

wants to merge 2 commits into from

Conversation

MikeFE
Copy link

@MikeFE MikeFE commented Jul 13, 2017

Ensure we enable cultureFallback for contact information fields in the
repository sidebar.

Mike Gale added 2 commits July 13, 2017 15:35
Remove dead code
12d0603
Add cultureFallback contacts, refs #11359
a31d878 
Ensure we enable cultureFallback for contact information fields in the
repository sidebar.
@qubot qubot force-pushed the dev/issue-11359-sidebar-contact-fallback branch from 9c5267b to a31d878 Compare July 13, 2017 22:41
jraddaoui
jraddaoui approved these changes Jul 14, 2017
View reviewed changes
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely be a partial, maybe for another time. Looks good!

@MikeFE
Copy link
Author

MikeFE commented Jul 19, 2017

203bdfd

@MikeFE MikeFE closed this Jul 19, 2017
@qubot qubot deleted the dev/issue-11359-sidebar-contact-fallback branch July 19, 2017 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jraddaoui jraddaoui jraddaoui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeFE @jraddaoui