Dev/issue 11311 csv format check #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jraddaoui
approved these changes
Sep 20, 2017
There was a problem hiding this comment.
Looks great @mcantelon!
Please, make sure to merge with squash and reference the ticket in the commit message.
qubot
force-pushed
the
dev/issue-11311-csv-format-check
branch
from
452d099
to
d4ff46b
Compare
* Allow actor export without specifying a standard (so we don't have to have two import/export config YAML files when just one will work) * Made flatfile export config file reading function accessible beyond the class * Added more import/export config YAML files (to describe the CSV columns that can be used when importing for AtoM data types that you can't yet export * Added check for a valid CSV file, factoring in what AtoM data type is being imported, before attempting to import (one needs to actually compare columns given an text file can technically be a CSV file)
qubot
force-pushed
the
dev/issue-11311-csv-format-check
branch
from
d4ff46b
to
fdc7e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added way to safeguard against users attempting to import non-CSV files as CSV.
Given any text file can technically be a CSV file, created logic to check the CSV header row and check what
column(s) are found to determine whether something seems like a legitimate CSV import.
specific to type of data being imported