Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logitech - Check and undo Aurora DLL patching #57

Open
RobertBeekman opened this issue May 4, 2021 · 1 comment
Open

Logitech - Check and undo Aurora DLL patching #57

RobertBeekman opened this issue May 4, 2021 · 1 comment
Assignees

Comments

@RobertBeekman
Copy link
Member

Aurora patches the Logitech SDK DLL, breaking Artemis Logitech support until the user reinstalles LGS or GHub.

We should detect and undo this as a prerequisite in the Logitech device provider.
Patching takes place here https://github.com/antonpup/Aurora/blob/master/Project-Aurora/Project-Aurora/App.xaml.cs#L545

Best we keep in mind our own wrapper and not break that.

@diogotr7
Copy link
Member

diogotr7 commented Sep 2, 2021

Looking into this at the moment. There's a few possibilities I need to account for:

  • None of the logitech softwares installed:

    We don't do anything here.

  • LGS is installed:

    In this case, the registry is not important. We just need to check the dll. If the aurora backup is present, restore that.

  • LGHUB is installed:

    The Aurora wrapper patch overwrites the LGHUB default registry path. We need to detect GHUB is installed and restore its original path. The dll in the LGS folder is then irrelevant, we don't need to touch it.

  • Both LGS and GHUB are installed:

    I'm not sure how to proceed here. Most likely the correct way to proceed is ignoring LGS is installed and just restore the original LGHUB path.

TLDR: we need to detect if the user has LGHUB and/or LGS installed first, and act according to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants