Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drainer searches in every StatefulSet of the cluster #132

Closed
brusdev opened this issue Jan 26, 2022 · 1 comment
Closed

Drainer searches in every StatefulSet of the cluster #132

brusdev opened this issue Jan 26, 2022 · 1 comment
Assignees
@RoddieKieley
Labels
bug Something isn't working

Comments

@brusdev
Copy link
Contributor

brusdev commented Jan 26, 2022

Describe the bug
The operator searches statefulsets across the entire cluster. It seam it is not impacting the drainer as it only performs the logic when the STS comes from a broker, but it has some penalties:

  • Performance: clusters with high number of STS could return a lot members to search within.
  • API calls: it can cause a lot of api calls, as it has to get complimentary information from some STSs that should are not needed (like PVCs).

To Reproduce
When deploying the operator and a new set of brokers is created with persistence and message migration enabled, the operator searches statefulsets across the entire cluster, to find the one related with the brokers.
@brusdev brusdev added the bug Something isn't working label Jan 26, 2022
brusdev added a commit to brusdev/activemq-artemis-operator that referenced this issue Jan 26, 2022
@brusdev
Add drainer filter to skip unrelated STSs (artemiscloud#132)
6333a01
brusdev added a commit to brusdev/activemq-artemis-operator that referenced this issue Jan 26, 2022
@brusdev
Add drainer filter to skip unrelated STSs (artemiscloud#132)
a16d09a
gaohoward added a commit that referenced this issue Jan 27, 2022
@gaohoward
Merge pull request #133 from brusdev/add_drainer_filter
2f4a4a2 
Add drainer filter to skip unrelated STSs (#132)
@gaohoward
Copy link
Collaborator

I'm closing it as the PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RoddieKieley RoddieKieley

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaohoward @RoddieKieley @brusdev