Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap label validation (and validation in general) in status condition #344

Closed
gtully opened this issue Oct 17, 2022 · 0 comments
Closed

Wrap label validation (and validation in general) in status condition #344

gtully opened this issue Oct 17, 2022 · 0 comments
Assignees
@gtully
Labels
enhancement New feature or request

Comments

@gtully
Copy link
Contributor

gtully commented Oct 17, 2022 •
edited

#340 has shown the need for some validation of the Cr, we can error out and not reconcile in this case. It would make sense to reflect this status in a condition. #330 introduced conditions in the status, which gate Ready.

Valid = True, can be gated on successful validation, with exact messages that capture what is invalid when it is false.
@gtully gtully added the enhancement New feature or request label Oct 17, 2022
@gtully gtully self-assigned this Oct 18, 2022
gtully added a commit to gtully/activemq-artemis-operator that referenced this issue Oct 18, 2022
@gtully
[artemiscloud#344] add valid status condition, reflect reserved label…
fe729d2 
… as failure reason, true otherwise
gtully added a commit that referenced this issue Oct 28, 2022
@gtully
[#344] add valid status condition, reflect reserved label as failure …
79fd094 
…reason, true otherwise
@gtully gtully closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtully gtully

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gtully