Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveMQArtemis CRDs v1.0.0 are not backward compatible with v0.20.1 #348

Closed
brusdev opened this issue Oct 19, 2022 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@brusdev
Copy link
Contributor

brusdev commented Oct 19, 2022

The redeliveryDelayMultiplier and RedeliveryCollisionAvoidanceFactor fields are *float32 in v2alpha5/v0.20.1 and they are *string in v2alpha5/v1.0.0.

@brusdev brusdev added the bug Something isn't working label Oct 19, 2022
@brusdev brusdev assigned RoddieKieley and brusdev and unassigned RoddieKieley Oct 19, 2022
brusdev added a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 19, 2022
brusdev added a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 19, 2022
gtully added a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 19, 2022
gtully added a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 19, 2022
ruromero pushed a commit to ruromero/activemq-artemis-operator that referenced this issue Oct 20, 2022
ruromero pushed a commit to ruromero/activemq-artemis-operator that referenced this issue Oct 20, 2022
brusdev added a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 25, 2022
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 25, 2022
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 25, 2022
brusdev added a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 25, 2022
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 25, 2022
brusdev added a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 25, 2022
gtully added a commit to brusdev/activemq-artemis-operator that referenced this issue Oct 26, 2022
gtully added a commit to gtully/activemq-artemis-operator that referenced this issue Oct 26, 2022
…our of brokerProperties, revert for v1alpha5
@gtully
Copy link
Contributor

gtully commented Oct 26, 2022

in the absence of a webhook conversion, supporting both types is not an option. further more, the inability to parse the v2alpha5 causes all operator watches to fail, leading to a head of the queue blocking problem, and the operator cannot get notification of further cr changes. Given that there is an alternative way to configure address settings in v1beta1 via broker properties and given that we don't yet have webhook conversion, and even that would have trouble with the type variance, the best option is to ignore these fields going forward.

gtully added a commit to gtully/activemq-artemis-operator that referenced this issue Oct 26, 2022
…our of brokerProperties, revert for v1alpha5
@gtully
Copy link
Contributor

gtully commented Oct 26, 2022

with this change, it won't be possible to create new cr's with redeliveryDelayMultiplier or redeliveryCollisionAvoidanceFactor AddressSettingsType fields in yaml:

$ kubectl apply  -f ./examples/artemis-basic-address-settings-deployment.yaml 
error: error validating "./examples/artemis-basic-address-settings-deployment.yaml": error validating data: ValidationError(ActiveMQArtemis.spec.addressSettings.addressSetting[1]): unknown field "redeliveryDelayMultiplier" in io.amq.broker.v1beta1.ActiveMQArtemis.spec.addressSettings.addressSetting; if you choose to ignore these errors, turn validation off with --validate=false

If necessary, they will have to be added to the brokerProperties Spec attribute.

Spec.BrokerProperties:
 - "addressSettings.#.redeliveryDelayMultiplier=2.1"
 - "addressSettings.#.redeliveryCollisionAvoidanceFactor=1.2"

gtully added a commit that referenced this issue Oct 26, 2022
@gtully gtully closed this as completed Oct 26, 2022
ruromero pushed a commit to ruromero/activemq-artemis-operator that referenced this issue Oct 28, 2022
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Nov 7, 2022
…our of brokerProperties, revert for v1alpha5

(cherry picked from commit 111470f)

downstream: ENTMQBR-7363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants