Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade has issue with existing services that don't have owner reference set #362

Closed
gtully opened this issue Oct 28, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@gtully
Copy link
Contributor

gtully commented Oct 28, 2022

Earlier versions of the operator did not always set the owner reference on services, on upgrade this leads to a clash when the current operator attempts to create what it needs on reconcile, it will not update b/c the missing owner reference means it does not get into the deployed list. This happens when console.Expose is true.

Errors of the form:

INFO    package k8s_actions    Creating new *v1.Service    {"ActiveMQArtemis Name": "amq-wconsj-0-svc", "Namespace": "amq"}
ERROR    package k8s_actions    Failed to create new *v1.Service    {"ActiveMQArtemis Name": "amq-wconsj-0-svc", "Namespace": "amq", "error": "Service \"amq-wconsj-0-svc\" is invalid: spec.clusterIPs: Invalid value: []string{\"172.30.231.228\"}: failed to allocate IP 172.30.231.228: provided IP is already allocated"}
 manager github.com/artemiscloud/activemq-artemis-operator/controllers(*ActiveMQArtemisReconcilerImpl).createRequestedResource

We should look for and claim any existing services that will clash on create.

@gtully gtully added the bug Something isn't working label Oct 28, 2022
@gtully gtully self-assigned this Oct 28, 2022
gtully added a commit to gtully/activemq-artemis-operator that referenced this issue Oct 28, 2022
brusdev pushed a commit that referenced this issue Oct 31, 2022
michalxo pushed a commit to michalxo/activemq-artemis-operator that referenced this issue Nov 2, 2022
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Nov 7, 2022
…e an owner reference and reclaim

(cherry picked from commit c47c81c)

downstream: ENTMQBR-7379
gtully added a commit to gtully/activemq-artemis-operator that referenced this issue Nov 7, 2022
@gtully
Copy link
Contributor Author

gtully commented Nov 7, 2022

this issue also occurs for any acceptor or connector references in the CR, these services need to be reclaimed too

gtully added a commit to gtully/activemq-artemis-operator that referenced this issue Nov 7, 2022
gtully added a commit that referenced this issue Nov 7, 2022
@gtully gtully closed this as completed Nov 8, 2022
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Dec 12, 2022
…have the same problem on upgrade

(cherry picked from commit b37d7f5)
downstream: ENTMQBR-7402
gaohoward pushed a commit to gaohoward/activemq-artemis-operator-1 that referenced this issue Jun 28, 2023
gaohoward pushed a commit to gaohoward/activemq-artemis-operator-1 that referenced this issue Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant