Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cascade delete foreground does not work #386

Closed
gtully opened this issue Nov 18, 2022 · 2 comments
Closed

cascade delete foreground does not work #386

gtully opened this issue Nov 18, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@gtully
Copy link
Contributor

gtully commented Nov 18, 2022

Describe the bug
oc delete activemqartemis ex-aao --cascade=foreground

that will cause the CR to hang with a foreground finalizer - expecting the controller to remove any dependent objects, which will not happen.

Expected behavior
the CR should be deleted, in the same way as with the default background cascade option

@gtully gtully added the bug Something isn't working label Nov 18, 2022
@gtully gtully self-assigned this Nov 18, 2022
@gtully
Copy link
Contributor Author

gtully commented Nov 18, 2022

currently we set an owner ref to the CR
OwnerReference{Kind:ActiveMQArtemis,Name:broker-amq,UID:29488c4a-052e-4bc6-afff-d9380c94d48e,APIVersion:broker.amq.io/v1beta1,Controller:*true,BlockOwnerDeletion:*true}

we need to leave BlockOwnerDeletion at the nil/default false.
OwnerReference{Kind:ActiveMQArtemis,Name:broker-amq,UID:29488c4a-052e-4bc6-afff-d9380c94d48e,APIVersion:broker.amq.io/v1beta1,Controller:*true}

gtully added a commit to gtully/activemq-artemis-operator that referenced this issue Nov 18, 2022
…er ref we set as we don't honour the foregound finalizer - and don't have a reason too
@gtully
Copy link
Contributor Author

gtully commented Nov 18, 2022

gaohoward pushed a commit that referenced this issue Nov 21, 2022
…t as we don't honour the foregound finalizer - and don't have a reason too
@gtully gtully closed this as completed Nov 29, 2022
gaohoward pushed a commit to gaohoward/activemq-artemis-operator-1 that referenced this issue Jun 28, 2023
…er ref we set as we don't honour the foregound finalizer - and don't have a reason too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant