Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relax the version validation, using condition unknown for non fatal version conflicts #591

Closed
gtully opened this issue May 15, 2023 · 0 comments
Closed

relax the version validation, using condition unknown for non fatal version conflicts #591

gtully opened this issue May 15, 2023 · 0 comments
Assignees
@gtully
Labels
bug Something isn't working

Comments

@gtully
Copy link
Contributor

gtully commented May 15, 2023

Describe the bug
Validation is asserting that both image and init image are configured together and that version or image are configured. this is the "safe" approach where there is always alignment. However existing crs use version and just an init image. This is problematic but may work. By relaxing the validation to flag the problem but still reconcile and provide the relevant details in the status, we can better support existing deployments.

This is a follow up on: #516
@gtully gtully added the bug Something isn't working label May 15, 2023
@gtully gtully self-assigned this May 15, 2023
gtully added a commit to gtully/activemq-artemis-operator that referenced this issue May 15, 2023
@gtully
[artemiscloud#591] relax version related validation - use unknown con…
8a3df35 
…dition reason on failure
gaohoward pushed a commit that referenced this issue May 16, 2023
@gtully @gaohoward
[#591] relax version related validation - use unknown condition reaso…
30f8bb5 
…n on failure
@gtully gtully closed this as completed May 16, 2023
gtully added a commit that referenced this issue May 16, 2023
@gtully
[#591] - use future proof version string
c2496c4
RoddieKieley pushed a commit to RoddieKieley/activemq-artemis-operator that referenced this issue May 18, 2023
@gtully
[artemiscloud#591] - use future proof version string
b801e71 
(cherry picked from commit c2496c4)

downstream: ENTMQBR-7923
RoddieKieley pushed a commit to RoddieKieley/activemq-artemis-operator that referenced this issue May 18, 2023
@gtully
[artemiscloud#591] relax version related validation - use unknown con…
7f34f5c 
…dition reason on failure

(cherry picked from commit 30f8bb5)

downstream: ENTMQBR-7923
gaohoward pushed a commit to gaohoward/activemq-artemis-operator-1 that referenced this issue Jun 28, 2023
@gtully @howardgao
[artemiscloud#591] relax version related validation - use unknown con…
9987ffd 
…dition reason on failure
gaohoward pushed a commit to gaohoward/activemq-artemis-operator-1 that referenced this issue Jun 28, 2023
@gtully @howardgao
[artemiscloud#591] - use future proof version string
af265cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtully gtully

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gtully