Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support container level security context #683

Closed
zamsong123 opened this issue Sep 15, 2023 · 10 comments
Closed

Support container level security context #683

zamsong123 opened this issue Sep 15, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@zamsong123
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently our EKS environment have some pre check on the container level security context, deployment will be blocked if not set

Describe the solution you'd like
Add a field to specify container level security context

@zamsong123 zamsong123 added the enhancement New feature or request label Sep 15, 2023
@zamsong123
Copy link
Contributor Author

will make changes and create PR to this issue

@brusdev
Copy link
Contributor

brusdev commented Sep 29, 2023

@zamsong123 the containers should inherit the pod level security context, are you setting the field spec.deploymentPlan.podSecurityContext in your ActiveMQArtemis CR?

@zamsong123
Copy link
Contributor Author

@brusdev thanks for your comments, in our case, our EKS supporting team is doing some restriction on this, e.g. if there's no container level "runAsRootUser": true is set, the deployment will be blocked, frankly speaking I am not sure how the inherit works, but I guess they are different configuration for different purpose

@zamsong123
Copy link
Contributor Author

@brusdev yes I tried the spec.deploymentPlan.podSecurityContext, it's not working for our EKS requirement

@zamsong123
Copy link
Contributor Author

@brusdev btw, in Confluent Operator, they are also separate config for different purpose

@brusdev
Copy link
Contributor

brusdev commented Oct 3, 2023

@zamsong123 thanks for the clarification, your enhancement makes sense to me

@Eric84626
Copy link
Contributor

I will make code change for this issue.

@brusdev
Copy link
Contributor

brusdev commented Oct 10, 2023

@Eric84626 cool, contributions are always welcome!

brianwarner pushed a commit to fidelity-contributions/artemiscloud-activemq-artemis-operator that referenced this issue Dec 14, 2023
brianwarner pushed a commit to fidelity-contributions/artemiscloud-activemq-artemis-operator that referenced this issue Dec 14, 2023
brianwarner pushed a commit to fidelity-contributions/artemiscloud-activemq-artemis-operator that referenced this issue Dec 14, 2023
…ityContext

Signed-off-by: Li, Eric <Xiannan.Li@fmr.com>
brianwarner pushed a commit to fidelity-contributions/artemiscloud-activemq-artemis-operator that referenced this issue Dec 14, 2023
brianwarner pushed a commit to fidelity-contributions/artemiscloud-activemq-artemis-operator that referenced this issue Dec 14, 2023
brianwarner pushed a commit to fidelity-contributions/artemiscloud-activemq-artemis-operator that referenced this issue Dec 14, 2023
@brusdev
Copy link
Contributor

brusdev commented Jan 2, 2024

The customisation of managed resources from #758 is sufficient to customize container security contexts however to simplify the deployment in restricted Kubernetes namespace I created #799 to restrict security context of pods by default.

@brusdev brusdev closed this as completed Jan 2, 2024
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Feb 20, 2024
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Feb 20, 2024
@brusdev brusdev reopened this Feb 20, 2024
brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Feb 21, 2024
@brusdev
Copy link
Contributor

brusdev commented Feb 21, 2024

The new field spec.deploymentPlan.containerSecurityContext to customize the container security contexts will be included in 1.1.0

@brusdev brusdev closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants