Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of init container can break brokerProperties system property set via JAVA_OPTS in profile, using JDK_JAVA_OPTIONS would just fix that #711

Closed
gtully opened this issue Oct 12, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@gtully
Copy link
Contributor

gtully commented Oct 12, 2023

If an init container replaces the artemis.profile, any modification via JAVA_OPTS are lost, leading to a loss of the operator supplied system property and missing properties.

 message: 'Status out of sync - missing status entry for keys: [broker.properties]'
 reason: OutOfSync
 status: Unknown
 type: BrokerPropertiesApplied```

Using JDK_JAVA_OPTIONS env var to directly configure the jvm will avoid this problem of inter-dependence on the run scripts etc.
 
@gtully gtully added the bug Something isn't working label Oct 12, 2023
@gtully gtully self-assigned this Oct 12, 2023
gtully added a commit to gtully/activemq-artemis-operator that referenced this issue Oct 12, 2023
@brusdev
Copy link
Contributor

brusdev commented Oct 17, 2023

The fix will be included in 1.0.16

@brusdev brusdev closed this as completed Oct 17, 2023
@gtully
Copy link
Contributor Author

gtully commented Oct 17, 2023

Note: the jvm outputs to stderr that the env var is in use. That is a little too verbose for our use case, but I think being independent of the run scripts is advantageous.
see: https://docs.oracle.com/en/java/javase/11/tools/java.html#GUID-3B1CE181-CD30-4178-9602-230B800D4FAE__USINGTHEJDK_JAVA_OPTIONSLAUNCHERENV-F3C0E3BA:~:text=.%20When%20JDK_JAVA_OPTIONS%20is%20set%2C%20the%20launcher%20prints%20a%20message%20to%20stderr%20as%20a%20reminder.

brianwarner pushed a commit to fidelity-contributions/artemiscloud-activemq-artemis-operator that referenced this issue Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants