#144 - expose Liveness and Readiness probes #145
Conversation
|
dont merge this just yet |
|
Actually its just because of the docs so this can be merged if @brusdev can verify the docs wrt to what the new acceptorname arg will be |
There was a problem hiding this comment.
I fetched, checked out, built, and deployed the operator as built by your branch. I saw that the operator started and that the liveness and readiness probe values were as expected.
However when I updated the livenessProbe and readinessProbe sections from {} to include the initialDelaySeconds: 32 (instead of the default 30) I expected to see the values reflected both in the CR upon reload in the openshift interface as well as see the values reflected in both the container yaml in the pod spec as well as the openshift interface when looking at the details for the container in the pod.
Neither had updated values, but I haven't tested enough to know why this might be the case. Did value updates work for an already deployed broker cluster in either kubernetes or openshift for you?
andytaylor
force-pushed
the
probes
branch
2 times, most recently
from
2b8fbdf
to
ccb1c88
Compare
|
@RoddieKieley fixed th eupdate issue and added a test. This is good to go now |
docs/manual/operator.md
Outdated
| livenessProbe: | ||
| exec: | ||
| commandport: |
| @@ -217,6 +221,12 @@ func (reconciler *ActiveMQArtemisReconcilerImpl) ProcessStatefulSet(fsm *ActiveM | |||
| fsm.SetPodInvalid(false) | |||
| newPodTemplateCreated = true | |||
| } | |||
|
|
|||
| if !processLivenessProbe(fsm.customResource, fsm.prevCustomResource) || !processReadinessProbe(fsm.customResource, fsm.prevCustomResource) { | |||
| *fsm.prevCustomResource = *fsm.customResource | |||
There was a problem hiding this comment.
what's the purpose of this assignment?
There was a problem hiding this comment.
I understand now. It's used to save the custome resource before the NewPodTemplateSpecForCR(fsm) which causes all pods to restart and a new reconcile.
No description provided.