remove state from broker/artemis controller #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi #185 prevents the removing of state from the address controller. |
gtully
force-pushed
the
remove_state_from_artemis_controller
branch
from
905da14
to
2dd3263
Compare
gtully
commented
Mar 30, 2022
|
going to sort that security update. but please review independent of that! |
gtully
force-pushed
the
remove_state_from_artemis_controller
branch
from
2dd3263
to
2ea43f3
Compare
This was referenced Apr 6, 2022
gtully
force-pushed
the
remove_state_from_artemis_controller
branch
from
ba4858f
to
7fbf022
Compare
|
pushed a rebase against main |
gtully
commented
Apr 8, 2022
gtully
force-pushed
the
remove_state_from_artemis_controller
branch
2 times, most recently
from
9d35446
to
b146b05
Compare
gaohoward
approved these changes
May 9, 2022
…an be left behind via creation time
…bose option to see all of the events that the operator listens for
gtully
force-pushed
the
remove_state_from_artemis_controller
branch
2 times, most recently
from
a1ed10b
to
2bd4cb1
Compare
gtully
force-pushed
the
remove_state_from_artemis_controller
branch
from
2bd4cb1
to
49fc919
Compare
|
I have re based, test good locally, however I saw this CI fail without good reason, so there is some timing related issue in play. It would be good if somone could try and reproduce a local failure. The ci just does make test. |
|
will try that on my local |
|
but didn't see the failure? all passed @gtully |
|
@gaohoward thanks. I think i have located the problem on the latest failed ci test - and have just sorted it, the eventually needed to include the get. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.