[#295] support envVar[] in the CR #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaohoward
approved these changes
Sep 1, 2022
|
@gtully @brusdev @RoddieKieley We should probably bump the crd version first? i.e. merge this pr befor that: |
|
For additions, we can stick with the CRD version. We really only have to bump when we are breaking existing CRs. |
|
@gtully @brusdev @RoddieKieley ok. I'd then suggest we cut a new tag before merging any additions. |
brusdev
reviewed
Sep 2, 2022
brusdev
approved these changes
Sep 6, 2022
|
going to add some doc, and noticed the name annotation is wrong! |
gtully
force-pushed
the
add_env_to_spec
branch
from
49f5e27
to
18f2267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.