Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#402] Support Floating x or x.y version is Artemis CRD version string #403

Merged
merged 1 commit into from Dec 23, 2022

Conversation

gaohoward
Copy link
Collaborator

No description provided.

controllers/activemqartemis_controller_test.go Outdated Show resolved Hide resolved
controllers/activemqartemis_controller_test.go Outdated Show resolved Hide resolved
controllers/activemqartemis_reconciler.go Outdated Show resolved Hide resolved
@gtully
Copy link
Contributor

gtully commented Dec 22, 2022

great.

I wonder, if we are to do some version aware code in the operator, do we need to drop the image url option? Or do we have a way to extract the version from the image?

If we can't easily infer the version from the image, and if it is a custom image I think we can't without some authenticated query to the registry, do we need to support some sort of "-final" postfix to a version string to say - no updates.
Even that will be problematic if the mapped image url changes under the hood, we will need to annotate the CR to mark the first image we resolved to in the -final case. This may not be ideal.

some food for thought.

@gaohoward
Copy link
Collaborator Author

great.

I wonder, if we are to do some version aware code in the operator, do we need to drop the image url option? Or do we have a way to extract the version from the image?

If we can't easily infer the version from the image, and if it is a custom image I think we can't without some authenticated query to the registry, do we need to support some sort of "-final" postfix to a version string to say - no updates. Even that will be problematic if the mapped image url changes under the hood, we will need to annotate the CR to mark the first image we resolved to in the -final case. This may not be ideal.

some food for thought.

Yeah there are certainly places to improve. I put the though into this #430 for tracking and discussion.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Floating x or x.y version is Artemis CRD version string
3 participants