Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#588] support template for custom labels and annotations that can ma… #737

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

gtully
Copy link
Contributor

@gtully gtully commented Nov 10, 2023

…tch any supporting resource managed by the operator

api/v1beta1/activemqartemis_types.go Outdated Show resolved Hide resolved
controllers/activemqartemis_reconciler.go Show resolved Hide resolved
controllers/activemqartemis_reconciler.go Show resolved Hide resolved
docs/help/operator.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@gaohoward gaohoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me in general.

@brusdev
Copy link
Contributor

brusdev commented Nov 20, 2023

@gtully great work!!! The full test-suite passes without failures.

… that can match any supporting resource managed by the operator
@gtully gtully merged commit efddfe5 into artemiscloud:main Nov 21, 2023
2 checks passed
@gtully
Copy link
Contributor Author

gtully commented Nov 21, 2023

if cert manager annotations extend to pkcs12 keystore creation that will be an additional usecase sorted, see: cert-manager/cert-manager#3799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants