-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement find references for #hashtags #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheBlob42 thanks for submitting a pull request! It's pretty close but needs a few tweaks. Let me know if you want to give it another round based on the comments.
Hey @artempyanykh thanks for the feedback 👍 I will have a look at them throughout the next days and either ask questions or adapt my PR for it |
I have adopted the PR according to your comments or at least how I understood them and to my best understanding. The project builds but the find "references functionality" does not work anymore for me. @artempyanykh maybe you could have a look into the last commit I made with the adaptions to see if I have misunderstood some of your points or made some other mistake that explains this I have the feeling that I might have misunderstood some of the points made 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR. There are just a couple small changes that are required to make this work.
Ideally, it'd be great to add a test for tag references resolution under RefsTest
but up to you.
I have adopted the code and it is working again. Let me know if you see any further issues or things to improve 🙂 |
@TheBlob42 thanks for adding the tests! One last thing is please run |
All looks good! Thanks for contributing @TheBlob42! |
Thanks you very much for all the guidance and patience 🙂 ❤️ |
Hi @artempyanykh is it possible to show tags as LSP document symbols? Currently we can use references and autocompletion for hastags but cannot use lsp document symbol method to list tags (since it only lists headers). |
@petobens it's possible, yes. Could you file a separate issue for this? |
Sure. Done in #261 |
fixes #194
Followed the guidance by @artempyanykh in the ticket. Thanks for this 👍 Without it I would have needed way more time to find myself around the project.
Tested with Neovim and it works as expected:
I just want to note that I have never coded in F# before and I did not really read into all its specialties and so on. Therefore please point out parts that could be improved or be written in a more F# way for me to learn.