-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonLdMulti - Remove requirement for 2 items #276
Conversation
LGTM; |
Implementing unit test for single record output
Is it correct that Travis CI is not running? I don't know if Scrutinizer covers running all the tests. |
We must configure github actions :( |
Hey guys, I ran into the same issue as #275. What's the status of this PR? Thanks! 😄 |
This broke my existing implementation 😅 |
@axyr I'm sorry to hear that. This fix make it behave as it it should be and as it is described in the documentation. |
Hi, No problem at all, just wanted to let you know! The tags stopped being printed in the blade template. I haven't got to the bottom to it yet, as downgrading was the fasted solution. Thanks for this nice package! |
JsonLdMulti
does not output anything on default; this is inconsistent with the use ofJsonLd
.The impact is high because this makes
JsonLdMulti
not be usable as default replacement forJsonLd
.This pull request removes the check for minimum 2 items.