Merging the "merging upstream" branch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ValueSetsBytesParser
…rser fix mysql import error. uninitialized constant.
… Rails – just activerecord.
maintainers of adapter gems should be tasked with creating a file in the adapters folder instead of forcing a file to be present within AR-import adapters folder if `require` does not find a file in the first entry on the gem load path it will move on to the next, multiple folders that have adapters in them will be referenced instead of requiring that each adapter be registered withing AR-import, this is how AR has adapters that are dynamically loadable and do not require each adapter to be referenced in the AR gem
let load paths determine which adapter is required a la activerecord adapters
Only add columns that haven't already been added
Instead, rely on basic behavior which supports non-optimized imports. [zdennis#131]
documentation for additional adapters
add ruby license and specify in gemspec.
…pter add jdbcpostgresql support
…-debug-gem Fix "ruby-debug" listed more than once "warning"
(partially, jruby and sqlite3 not runnning so far)
Adding support for ActiveRecord 4.2
…time-related test which was failing with active record 3.2 due to timezone issues.
Set the ActiveRecord::Base timezone to UTC for tests
…mport Adding the ability to use #import thru a has many association.
…anked and 2.8.1 does not seem to build on OS X 10.10
This pins the Gemfile to 1.0.3 which seems to work.
em-synchrony 1.0.4 seems to be broken
Relax restrictions on mysql for AR 3.1 and 3.2
place the id return into every model and mark the model as clean? (since it has been saved) make the patch work for non-standard primary keys modification showing how save a tree of objects efficiently. pass options down into sub-objects that are imported set the foreign key on a sub-collection when the parent is imported tests for importing 3 levels of objects new model for testing 3 levels of objects: chapter move the setting of ids down into the postgresql adapter.
…ulk import, we want to bypass the proxy association and use the underlying target. Do this by marking each association as loaded
…lling some SQL. I think pulling the autofollowing of associations out helps that
…or a reason. Present self _kicks_ past self.
…de do its job. This removes the chance of name collision and ensures we can call the original method with super.
Reverts commit 8e11c8a.
…mport return the inserted ids for postgres bulk insert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently "merging upstream" should have been the baseline. Given that this gem exists and is maintained, not sure why Arthrex has their own version?