Model changed? still returns true after being synchronized

[jturkel]

After importing models using the synchronize option calling model.changed? still returns true e.g.

models = [MyModel.new(id: 777)]
MyModel.import(models, validate: false, synchronize: models)
puts "Changed: #{models.first.changed?}"

Looks like a pretty straightforward fix by adding instance.changed_attributes.clear in synchronize.rb. I'd be happy to put together a pull request if you agree this is a bug.

[zdennis]

activerecord-import 0.5.0 has been pushed to rubygems with this in there. Thanks again!

[zflat]

In rails 4.1 and 4.2 I have been getting errors like:

#Class:0x00000002e2ead0#test_#import with :synchronize option synchronizing on destroyed records with explicit conditions_reloads data for existing in-memory instances:
NoMethodError: undefined method changed_in_place_from?' for 1:Fixnum /...j/activerecord-import/test/import_test.rb:160:inblock (4 levels) in <top (required)>'

#Class:0x00000002e2ead0#test_#import with :synchronize option synchronizing on destroyed records with explicit conditions_reloads data for existing in-memory instances:
NoMethodError: undefined method `each' for nil:NilClass

#Class:0x00000002e81438#test_.synchronize_reloads data for the specified records:
NoMethodError: undefined method `changed_in_place_from?' for 1:Fixnum

#Class:0x00000002e81438#test_.synchronize_reloads data for the specified records:
NoMethodError: undefined method `each' for nil:NilClass

#Class:0x00000002e81438#test_.synchronize_the synchronized records aren't dirty:
NoMethodError: undefined method `changed_in_place_from?' for 1:Fixnum

#Class:0x00000002e81438#test_.synchronize_the synchronized records aren't dirty:
NoMethodError: undefined method `each' for nil:NilClass

#Class:0x00000002e2bc40#test_#import with :synchronize option synchronizing on new records with explicit conditions_reloads data for existing in-memory instances:
NoMethodError: undefined method `value_before_type_cast' for 1:Fixnum

Changes to #synchronize fixes this for rails 4.1, but breaks it for rails 3.2.
See my fork at https://github.com/zflat/activerecord-import/tree/issue123-sync