Bug 17767: Move 'JavaScript disabled' to top of Security Slider list

arthuredelstein · Sep 12, 2016 · fe6c10c · fe6c10c
1 parent 57002e8
commit fe6c10c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 22 deletions.
diff --git a/src/chrome/content/preferences.xul b/src/chrome/content/preferences.xul
@@ -78,13 +78,17 @@
                   &torbutton.prefs.sec_gen_desc;
                 </description>
                 <description class="slider-text-size"
-                  tooltiptext="&torbutton.prefs.sec_html5_tooltip;">
-                  &torbutton.prefs.sec_html5_desc;
+                  tooltiptext="&torbutton.prefs.sec_js_desc_tooltip;">
+                  &torbutton.prefs.sec_all_js_desc;
                 </description>
                 <description class="slider-text-size"
                   tooltiptext="&torbutton.prefs.sec_jit_desc_tooltip; &torbutton.prefs.sec_baseline_jit_desc_tooltip;">
                   &torbutton.prefs.sec_all_jit_desc; &torbutton.prefs.sec_jit_slower_desc;
                 </description>
+                <description class="slider-text-size"
+                  tooltiptext="&torbutton.prefs.sec_html5_tooltip;">
+                  &torbutton.prefs.sec_html5_desc;
+                </description>
                 <description class="slider-text-size"
                   tooltiptext="&torbutton.prefs.sec_jar_tooltip;">
                   &torbutton.prefs.sec_jar_desc;
@@ -97,10 +101,6 @@
                   tooltiptext="&torbutton.prefs.sec_font_rend_svg_tooltip;">
                   &torbutton.prefs.sec_font_rend_desc;
                 </description>
-                <description class="slider-text-size"
-                  tooltiptext="&torbutton.prefs.sec_js_desc_tooltip;">
-                  &torbutton.prefs.sec_all_js_desc;
-                </description>
                 <description class="slider-text-size"
                   tooltiptext="&torbutton.prefs.sec_svg_desc_tooltip;">
                   &torbutton.prefs.sec_svg_desc;
@@ -116,13 +116,17 @@
                   &torbutton.prefs.sec_gen_desc;
                 </description>
                 <description class="slider-text-size"
-                  tooltiptext="&torbutton.prefs.sec_html5_tooltip;">
-                  &torbutton.prefs.sec_html5_desc;
+                  tooltiptext="&torbutton.prefs.sec_js_desc_tooltip;">
+                  &torbutton.prefs.sec_js_https_desc;
                 </description>
                 <description class="slider-text-size"
                   tooltiptext="&torbutton.prefs.sec_jit_desc_tooltip; &torbutton.prefs.sec_baseline_jit_desc_tooltip;">
                   &torbutton.prefs.sec_all_jit_desc; &torbutton.prefs.sec_jit_slower_desc;
                 </description>
+                <description class="slider-text-size"
+                  tooltiptext="&torbutton.prefs.sec_html5_tooltip;">
+                  &torbutton.prefs.sec_html5_desc;
+                </description>
                 <description class="slider-text-size"
                   tooltiptext="&torbutton.prefs.sec_jar_tooltip;">
                   &torbutton.prefs.sec_jar_desc;
@@ -135,24 +139,20 @@
                   tooltiptext="&torbutton.prefs.sec_font_rend_svg_tooltip;">
                   &torbutton.prefs.sec_font_rend_desc;
                 </description>
-                <description class="slider-text-size"
-                  tooltiptext="&torbutton.prefs.sec_js_desc_tooltip;">
-                  &torbutton.prefs.sec_js_https_desc;
-                </description>
               </vbox>
              <vbox id="desc_medium_low" collapsed="true">
                 <description
                   class="slider-text-size, slider-text-weight">
                   &torbutton.prefs.sec_gen_desc;
                 </description>
-                <description class="slider-text-size"
-                  tooltiptext="&torbutton.prefs.sec_html5_tooltip;">
-                  &torbutton.prefs.sec_html5_desc;
-                </description>
                 <description class="slider-text-size"
                   tooltiptext="&torbutton.prefs.sec_jit_desc_tooltip;">
                   &torbutton.prefs.sec_some_jit_desc; &torbutton.prefs.sec_jit_slower_desc;
                 </description>
+                <description class="slider-text-size"
+                  tooltiptext="&torbutton.prefs.sec_html5_tooltip;">
+                  &torbutton.prefs.sec_html5_desc;
+                </description>
                 <description class="slider-text-size"
                   tooltiptext="&torbutton.prefs.sec_jar_tooltip;">
                   &torbutton.prefs.sec_jar_desc;
@@ -188,32 +188,32 @@
      <html:b>&torbutton.prefs.sec_gen_desc;</html:b>
      <html:br></html:br>
      <html:br></html:br>
+     <html:div>&torbutton.prefs.sec_all_js_desc;</html:div>
+     <html:div>&torbutton.prefs.sec_all_jit_desc; &torbutton.prefs.sec_jit_slower_desc;</html:div>
      <html:div>&torbutton.prefs.sec_html5_desc;</html:div>
-     <html:div>&torbutton.prefs.sec_some_jit_desc;</html:div>
      <html:div>&torbutton.prefs.sec_jar_desc;</html:div>
      <html:div>&torbutton.prefs.sec_mathml_desc;</html:div>
      <html:div>&torbutton.prefs.sec_font_rend_desc;</html:div>
-     <html:div>&torbutton.prefs.sec_all_js_desc;</html:div>
      <html:div>&torbutton.prefs.sec_svg_desc;</html:div>
      <html:div>&torbutton.prefs.sec_webfonts_desc;</html:div>
    </tooltip>
    <tooltip id="mh_preview">
      <html:b>&torbutton.prefs.sec_gen_desc;</html:b>
      <html:br></html:br>
      <html:br></html:br>
+     <html:div>&torbutton.prefs.sec_js_https_desc;</html:div>
+     <html:div>&torbutton.prefs.sec_all_jit_desc; &torbutton.prefs.sec_jit_slower_desc;</html:div>
      <html:div>&torbutton.prefs.sec_html5_desc;</html:div>
-     <html:div>&torbutton.prefs.sec_some_jit_desc;</html:div>
      <html:div>&torbutton.prefs.sec_jar_desc;</html:div>
      <html:div>&torbutton.prefs.sec_mathml_desc;</html:div>
      <html:div>&torbutton.prefs.sec_font_rend_desc;</html:div>
-     <html:div>&torbutton.prefs.sec_js_https_desc;</html:div>
    </tooltip>
    <tooltip id="ml_preview">
      <html:b>&torbutton.prefs.sec_gen_desc;</html:b>
      <html:br></html:br>
      <html:br></html:br>
+     <html:div>&torbutton.prefs.sec_some_jit_desc; &torbutton.prefs.sec_jit_slower_desc;</html:div>
      <html:div>&torbutton.prefs.sec_html5_desc;</html:div>
-     <html:div>&torbutton.prefs.sec_some_jit_desc;</html:div>
      <html:div>&torbutton.prefs.sec_jar_desc;</html:div>
      <html:div>&torbutton.prefs.sec_mathml_desc;</html:div>
    </tooltip>

diff --git a/src/chrome/locale/en/torbutton.dtd b/src/chrome/locale/en/torbutton.dtd
@@ -47,7 +47,7 @@
 <!ENTITY torbutton.prefs.sec_mathml_desc "Some mechanisms of displaying math equations are disabled.">
 <!ENTITY torbutton.prefs.sec_mathml_desc_tooltip "MathML is disabled.">
 <!ENTITY torbutton.prefs.sec_med_high "Medium-High">
-<!ENTITY torbutton.prefs.sec_all_jit_desc "All JavaScript performance optimizations are disabled.">
+<!ENTITY torbutton.prefs.sec_all_jit_desc "On sites where JavaScript is enabled, performance optimizations are disabled.">
 <!ENTITY torbutton.prefs.sec_font_rend_desc "Some font rendering features are disabled.">
 <!ENTITY torbutton.prefs.sec_font_rend_graphite_tooltip "The Graphite font rendering mechanism is disabled.">
 <!ENTITY torbutton.prefs.sec_svg_desc "Some types of images are disabled.">