Cleanup mrbsys C extension
#1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `extern "C"` blocks when building with a C++ compiler so linkage behaves as expected. `class` is a keyword in C++, so rename parameters from `class` to `klass`. `_Bool` is a C99 keyword. Replace it with `bool` from `stdbool.h`.
Include what you use!
With the `Fixnum` deprecation in mruby 3.1.0, `mrb_fixnum_to_str` was renamed to `mrb_integer_to_str`. `mrb_fixnum_to_str` was retained as a macro alias for source compatibility. Update to the current stable function name.
lopopolo
added
A-C-API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mrbsysC extension to compile with a C++ compiler. See 24dd693 for details of these changes.#includes inmrbsys/src/ext.c.This PR was partially extracted from #1904 commit 9aa36b9.