Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup mrbsys C extension #1968

Merged
merged 4 commits into from
Jul 24, 2022
Merged

Cleanup mrbsys C extension #1968

merged 4 commits into from
Jul 24, 2022

Commits on Jul 24, 2022

  1. Fixup artichoke-backend cext to build with a C++ compiler 

    Add `extern "C"` blocks when building with a C++ compiler so linkage
behaves as expected.

`class` is a keyword in C++, so rename parameters from `class` to
`klass`.

`_Bool` is a C99 keyword. Replace it with `bool` from `stdbool.h`.
    @lopopolo
    lopopolo committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    24dd693 View commit details
    Browse the repository at this point in the history

  2. Clean up header includes in mrbsys ext.c 

    Include what you use!
    @lopopolo
    lopopolo committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    924c55d View commit details
    Browse the repository at this point in the history

  3. Update call to mrb_integer_to_str in mrbsys cext 

    With the `Fixnum` deprecation in mruby 3.1.0, `mrb_fixnum_to_str` was
renamed to `mrb_integer_to_str`. `mrb_fixnum_to_str` was retained as a
macro alias for source compatibility.

Update to the current stable function name.
    @lopopolo
    lopopolo committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    93c51cb View commit details
    Browse the repository at this point in the history

  4. Run clang-format

    @lopopolo
    lopopolo committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    3e2843a View commit details
    Browse the repository at this point in the history