[bigquery] Increase Storage Write API max request size #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
reviewed
Jun 18, 2024
| // Storage Write API is limited to 10 MB, let's start out conservative and use 80% of that. | ||
| maxRequestByteSize = 10_000_000 * .8 | ||
| // Storage Write API is limited to 10 MiB, subtract 50 KiB to account for request overhead. | ||
| maxRequestByteSize = (10 * 1024 * 1024) - (50 * 1024) |
There was a problem hiding this comment.
After a bunch of testing the cutoff seemed to be around 30 KiB so I decided to go with 50 KiB to be safe.
There was a problem hiding this comment.
I tested it it with a pretty wide table so I think it should be fine, but if we do see errors we can increase it to 100 KiB or higher.
Tang8330
reviewed
Jun 18, 2024
| @@ -223,7 +222,6 @@ func (s *Store) Dedupe(tableID sql.TableIdentifier, primaryKeys []string, includ | |||
| } | |||
|
|
|||
| func LoadBigQuery(cfg config.Config, _store *db.Store) (*Store, error) { | |||
| cfg.BigQuery.LoadDefaultValues() | |||
Tang8330
approved these changes
Jun 18, 2024
|
i c
…On Mon, Jun 17, 2024 at 10:09 PM Nathan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In clients/bigquery/bigquery.go
<#741 (comment)>:
> @@ -34,13 +34,12 @@ const (
describeNameCol = "column_name"
describeTypeCol = "data_type"
describeCommentCol = "description"
- // Storage Write API is limited to 10 MB, let's start out conservative and use 80% of that.
- maxRequestByteSize = 10_000_000 * .8
+ // Storage Write API is limited to 10 MiB, subtract 50 KiB to account for request overhead.
+ maxRequestByteSize = (10 * 1024 * 1024) - (50 * 1024)
After a bunch of testing the cutoff seemed to be around 30 KiB so I
decided to go with 50 KiB to be safe.
—
Reply to this email directly, view it on GitHub
<#741 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBVGKG6ALHTWWMRBPCT57DZH66G3AVCNFSM6AAAAABJPHXB2SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMRUGQ3TOOJTG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also kill
batchSizeconfig.