Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bigquery] Increase Storage Write API max request size #741

Merged
merged 2 commits into from
Jun 18, 2024
Merged

[bigquery] Increase Storage Write API max request size #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b5e43
[bigquery] Increase max size of requests to Storage Write API
nathan-artie Jun 18, 2024
2884164
Also kill batch size
nathan-artie Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions clients/bigquery/bigquery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,12 @@ const (
describeNameCol = "column_name"
describeTypeCol = "data_type"
describeCommentCol = "description"
// Storage Write API is limited to 10 MB, let's start out conservative and use 80% of that.
maxRequestByteSize = 10_000_000 * .8
// Storage Write API is limited to 10 MiB, subtract 50 KiB to account for request overhead.
maxRequestByteSize = (10 * 1024 * 1024) - (50 * 1024)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 50 kb fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a bunch of testing the cutoff seemed to be around 30 KiB so I decided to go with 50 KiB to be safe.

Copy link
Contributor Author

@nathan-artie nathan-artie Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it it with a pretty wide table so I think it should be fine, but if we do see errors we can increase it to 100 KiB or higher.

)

type Store struct {
configMap *types.DwhToTablesConfigMap
batchSize int
config config.Config

db.Store
Expand Down Expand Up @@ -223,7 +222,6 @@ func (s *Store) Dedupe(tableID sql.TableIdentifier, primaryKeys []string, includ
}

func LoadBigQuery(cfg config.Config, _store *db.Store) (*Store, error) {
cfg.BigQuery.LoadDefaultValues()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

if _store != nil {
// Used for tests.
return &Store{
Expand All @@ -250,7 +248,6 @@ func LoadBigQuery(cfg config.Config, _store *db.Store) (*Store, error) {
return &Store{
Store: store,
configMap: &types.DwhToTablesConfigMap{},
batchSize: cfg.BigQuery.BatchSize,
config: cfg,
}, nil
}
7 changes: 0 additions & 7 deletions lib/config/bigquery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,6 @@ type BigQuery struct {
DefaultDataset string `yaml:"defaultDataset"`
ProjectID string `yaml:"projectID"`
Location string `yaml:"location"`
BatchSize int `yaml:"batchSize"`
}

func (b *BigQuery) LoadDefaultValues() {
if b.BatchSize == 0 {
b.BatchSize = 1000
}
}

// DSN - returns the notation for BigQuery following this format: bigquery://projectID/[location/]datasetID?queryString
Expand Down