-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two problems when hooking SiglusEngine #34
Comments
ITHVNR worked fine for me with this game(金色ラブリッチェ), if that matters. The garbage hooks kept coming sometimes, but there always was at least one from the start which kept giving all the text needed. |
@Mars132 Does Textractor get any good hook on this game for you? |
@Artikash just tested with 3.2.2 a couple of times, seems to be pretty much the same as I had with ITHVNR. Just have to be more careful when searching for the hook, as it gives you list of about 40 hooks right away. I was able to firsttry finding the right one quite a lot by selecting about 3rd-7th number from the end. About 2-4 working hooks among the mess. |
Ok, looks like this isn't an issue ...jk it is. Kind of. Since every hook creates a new thread as well, and Windows only allows me to create at most a few hundred threads, Textractor will crash after going through a few hundred lines of this game. I'll fix ASAP (but RL is picking up for me about now, so ASAP might be a ways off). |
Also, I might suck at this terminology, those lines on the screenshot |
Yeah, each line is a thread. Having too many crashes. ITHVNR handled it with a hard cap on the number of threads that it would allow, I removed that. I have a better solution in mind. |
Scratch that. I've tried implementing my idea and it's bad for some other reasons. Gonna go back to ITHVNR method of thread count hard cap. |
Alright, fixed. |
Firstly, there are some hooks that continuously get senseless texts and never stop.
For example,
windowbtn_windowbtn_windowbtn_windowbtn_windowbtn_...
ormenu_menu_menu_menu_menu_menu_...
(you can have a glance at how many texts are get from the size of scrollbar)
The second one is, when new dialogue comes, a new thread created and output the text.
And when the next dialogue comes, a second thread created, output the text, and the first thread just does not output anything.
(many threads created)
BTW, I use AlphaROMdiE to crack the game, so I have no idea whether these could only happen on the cracked version or not.
The text was updated successfully, but these errors were encountered: