-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including CPU & Memory tracking function #1
Comments
Hello @mijikim. Is this for CPU and RAM usage of Minigun itself or of the target? I think that either way, one should be using external tools to monitor the processes, e.g. |
@hassy This will be for cpu and ram of the target. The use case will be me running a node application on my machine and collecting data of that application by supplying pid. And I am testing usage module to get the data. So instead of embedding this in minigun-core, you suggest a plugin for this feature? |
@mijikim I'm guessing you want to correlate the exact point in the load-test with where CPU/RAM usage spikes? Yes, it would be really useful to have this data available in the reports that Minigun generates, but for this feature to be built right into Minigun it would need to:
But if it were an optional plugin just for testing Node.js apps running locally, then the above doesn't necessarily need to apply. If you want to give it a go, I'd be happy to help (we'd need to figure out a plugin interface for Minigun). |
@hassy I see your point and agree that this should be a plugin. I am happy to create a plugin for a purpose to record cpu&memory on targets that are on the same machine. I would greatly appreciate your help as this will be my first time contributing to open source project :) |
(artilleryio#1) - Add cookie support
* feat: aggregate metrics by scenario name * Update README.md Add section for aggregateByName usage Co-authored-by: Hassy Veldstra <h@veldstra.org>
Hi, I think it will be great if minigun run command produces cpu & memory usage report.
I am testing this by incorporating usage module into minigun-core module and supplying pid in the JSON file that 'minigun run' command will read. If pid is not given, run command should work without collecting cpu & memory data. Would appreciate your opinion on this!
The text was updated successfully, but these errors were encountered: