Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using Wreck instead of Request #6

Closed
StevenWeathers opened this issue Aug 13, 2015 · 4 comments
Closed

Investigate using Wreck instead of Request #6

StevenWeathers opened this issue Aug 13, 2015 · 4 comments

Comments

@StevenWeathers
Copy link

Especially considering this applications goal is to load test something I would recommend against using Request module, its bloated and less performant than something like Wreck

@hassy
Copy link
Member

hassy commented Aug 14, 2015

@StevenWeathers Thanks for your suggestion. I haven't used Wreck myself and Request has been performant-enough for now. Wreck does not seem to be as featureful as Request either. I'd be interested in a performance comparison between the two. Is worse performance something you ran into with Request?

@hassy hassy changed the title Recommend changing Request module Investigate using Wreck instead of Request Aug 14, 2015
@StevenWeathers
Copy link
Author

While I agree Wreck isn't as featureful as request, that's one of the big reasons its a better use as its less bloated and requires far less dependencies. Overall I've seen better performance using Wreck than Request but haven't formally put together any benchmarks. I'll try to find time to do so in the near future and share them with you.

@hassy
Copy link
Member

hassy commented Oct 7, 2015

I'm working on a suite of benchmarks comparing Request and Wreck - so far I'm seeing that Request is ~20% slower - I'll update this when I have the final results.

tomgco pushed a commit to tomgco/minigun that referenced this issue Jan 6, 2016
(artilleryio#5) - Allow TLS configuration options in request
@hassy
Copy link
Member

hassy commented Jan 15, 2016

Closing - MG will continue to use Request by default as Wreck is too limited. A custom Wreck-based engine would be easy to implement if someone really wanted one.

@hassy hassy closed this as completed Jan 15, 2016
hassy added a commit that referenced this issue Jul 22, 2022
Add example to demonstrate tracking custom metrics
hassy added a commit that referenced this issue Jan 16, 2023
…2.25

build(deps): Bump esm from 3.0.84 to 3.2.25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants