fix: redirect chains with capture/afterResponse hooks #1568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our handling of redirect chains.
We currently run response processors on every response, so e.g. a
capture
can fail for the first response but succeed for the second response, leading to multiple callbacks toasync.waterfall
being invoked.This PR changes the logic to only run response processors on the last request in the chain.
It also refactors the code to get rid of
async.waterfall
.