Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playwright): emit errors #2677

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

InesNi
Copy link
Contributor

@InesNi InesNi commented Apr 26, 2024

Description

Emitting errors from the Playwright engine. This means that errors will show up in reports, and (for recorded tests) on Artillery Cloud dashboard as well.

For simplicity errors are divided in 2 groups:

  • Assertion errors caused by expect will be recorded as pw_failed_assertion.{expectation}
  • Any other errors will be recorded as {error.message}
Screenshot 2024-04-26 at 18 54 39 Screenshot 2024-04-26 at 18 52 39 Screenshot 2024-04-26 at 19 00 44

The error messages have been cleaned by removing any ANSI codes as well as any additional lines - just the first line is used

Testing:
Tested manually by causing multiple different failed assertions and errors types.

Note:

  • Error handling logic of the Playwright engine in general should be reexamined and addressed in a separate PR in necessary.

Pre-merge checklist

  • Does this require an update to the docs?
  • Does this require a changelog entry?

@InesNi InesNi requested a review from a team April 26, 2024 18:41
@InesNi InesNi merged commit 4b6546e into main Apr 29, 2024
21 checks passed
@InesNi InesNi deleted the ifazlic-art-1767-emit-errors-from-playwright-engine branch April 29, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants