Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write Playwright traces to a unique directory #2717

Merged
merged 3 commits into from
May 9, 2024

Conversation

hassy
Copy link
Member

@hassy hassy commented May 9, 2024

Description

  • Write Playwright traces to /tmp/$testRunId instead of just /tmp
    • This should fix ENOSPC errors on Fargate due to running out of file watchers
  • Use Chokidar's built-in API for detecting when a file is no longer changing, instead of hardcoded wait of 5 seconds

Pre-merge checklist

This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.

  • Does this require an update to the docs?
  • Does this require a changelog entry?

hassy added 3 commits May 9, 2024 14:23
Make the ID available to all plugins & engines
Use the API in Chokidar to detect when a file is ready, instead
of a static 5s wait.
@hassy hassy merged commit 99513b7 into main May 9, 2024
12 checks passed
@hassy hassy deleted the hassy-art-1808-enospc-errors-on-fargate branch May 9, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant