Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): use correct architecture in worker images #2773

Merged
merged 5 commits into from
May 22, 2024

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented May 21, 2024

Description

We now build x86_64 and arm64 images. Fargate will use x86_64 image by default (as it currently does), and Fargate will use arm64 by default (as it currently does).

Notes:

  • We don't test against arm64 in PRs due to how long it takes to build. We will make some changes separately to run that in main against a canary
  • Lambda functions will contain the architecture in the name to piggyback on existing name mechanism to determine if a new function is needed

Pre-merge checklist

  • Does this require an update to the docs? I don't think so, since no default behaviour was changed
  • Does this require a changelog entry? It could be highlighted, yes

@bernardobridge bernardobridge force-pushed the bernardobridge/art-1834-use-new-arch-images branch from 8291e7b to c090252 Compare May 22, 2024 16:13
@bernardobridge bernardobridge marked this pull request as ready for review May 22, 2024 16:38
@bernardobridge bernardobridge requested a review from a team May 22, 2024 16:38
@bernardobridge
Copy link
Contributor Author

bernardobridge commented May 22, 2024

Note: disregard failing test, it's a bug in zipfile introduced in https://github.com/artilleryio/artillery/pull/2767/files#diff-031b22251942a138a35ea32b4c6f9f4188824a499012ab4ca3a36be352d77568L202 .

Very easy fix (just use noPrefix if noPrefixPosix isn't there), but no point in fixing since zipfile is being deprecated in the other open PR, so all that code will be deleted shortly.

@bernardobridge bernardobridge merged commit 9c43ff4 into main May 22, 2024
27 of 28 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1834-use-new-arch-images branch May 22, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant