Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): set ADOT's cpu/memory config only if the container exists #3192

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix(ecs): set ADOT's cpu/memory config only if the container exists #3192

merged 1 commit into from
Jun 11, 2024

Conversation

hassy
Copy link
Member

@hassy hassy commented Jun 11, 2024

Description

Trying to run a test on an ECS EC2 container with artillery run-fargate --launch-type ecs:ec2 currently fails because Artillery tries to set cpu/memory config explicitly for ADOT containers on ECS EC2, which does not always exist.

Pre-merge checklist

This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.

  • Does this require an update to the docs? No
  • Does this require a changelog entry? Yes

@hassy hassy merged commit a49e371 into main Jun 11, 2024
30 checks passed
@hassy hassy deleted the hassy-art-1865-cant-run-tests-on-ecsec2 branch June 11, 2024 14:05
hassy added a commit that referenced this pull request Jun 20, 2024
@hassy
fix: avoid trying to set CPU/memory for ADOT when it's not enabled
ac9df42 
Follow up to #3192

The use of the spread operator leads to taskDefinition.containerDefinitions
always having a length of 2.

Ref: #3192
@hassy hassy mentioned this pull request Jun 20, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run-aws-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hassy