dep(core): use rc of tough-cookie to fix deprecated package #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobridge
changed the title
bernardobridge
deleted the
bernardobridge/art-1866-deprecation-notice-for-punycode-when-running-on-nodejs-21
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
punycodeis showing a deprecation notice when running the CLI on Node 21+. From what I can tell, this is coming fromtough-cookie, and they've solved the issue on the unreleased version 5. From what I've read, this is mostly a rewrite to Typescript, and should not contain functional changes. It's unknown when they'll officially release it.Pre-merge checklist